Skip to content

Conversation

@rado17
Copy link
Contributor

@rado17 rado17 commented Oct 31, 2025

No description provided.

@rado17 rado17 requested review from a team as code owners October 31, 2025 10:02
@NordicBuilder NordicBuilder added doc-required PR must not be merged without tech writer approval. manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 31, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 31, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
nrfxlib nrfconnect/sdk-nrfxlib@978e42a (main) nrfconnect/sdk-nrfxlib#1902 nrfconnect/sdk-nrfxlib#1902/files
zephyr nrfconnect/sdk-zephyr@164b47d nrfconnect/sdk-zephyr#3452 nrfconnect/sdk-zephyr#3452/files

DNM label due to: 2 projects with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 31, 2025

CI Information

To view the history of this post, click the 'edited' button above
Build number: 7

Inputs:

Sources:

hal_nordic: PR head: 979a58d0829108b57f10e90b6c3fc35ab6206e4b
sdk-nrf: PR head: ac07d9f275a1be64fd2b1329a0c030b08546a144
nrfxlib: PR head: b6ed449969cf72c3a6de18286f00de1e1056cdf6
hostap: PR head: 8de3d62b8b1fdb3257de67ed1784461a4fcf0c21
zephyr: PR head: a1b2c1d5af7a7191247e755c0af367d7e7ade00d

more details

hal_nordic:

PR head: 979a58d0829108b57f10e90b6c3fc35ab6206e4b
merge base: 979a58d0829108b57f10e90b6c3fc35ab6206e4b
Diff

sdk-nrf:

PR head: ac07d9f275a1be64fd2b1329a0c030b08546a144
merge base: 0e12c9f72fb9f8719f51043d67841343abe54284
target head (main): 0e12c9f72fb9f8719f51043d67841343abe54284
Diff

nrfxlib:

PR head: b6ed449969cf72c3a6de18286f00de1e1056cdf6
merge base: 664572979dd1a293a19c47e43749b42800be9c18
target head (main): 978e42a98059347786975aba97e73aea9bf63438
Diff

hostap:

PR head: 8de3d62b8b1fdb3257de67ed1784461a4fcf0c21
merge base: 5abcff1c0ecff65f0f81e0cc086b7f766e5101bf
target head (main): 6086dea5ee7406e1eede7f2ca6dff1b00b0f04e2
Diff

zephyr:

PR head: a1b2c1d5af7a7191247e755c0af367d7e7ade00d
merge base: c6dbf158a0b8c45beb78aa76412d99f60cd6467f
target head (main): ce93adad8c5ae914f9229f4017e9a0b4c437f159
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (43)
doc
│  ├── nrf
│  │  ├── protocols
│  │  │  ├── wifi
│  │  │  │  ├── index.rst
│  │  │  │  │ wifi_direct.rst
modules
│  ├── hal
│  │  │ nordic
│  ├── lib
│  │  ├── hostap
│  │  │  ├── hostapd
│  │  │  │  ├── hostapd_cli_zephyr.c
│  │  │  │  │ hostapd_cli_zephyr.h
│  │  │  ├── src
│  │  │  │  ├── ap
│  │  │  │  │  │ hostapd.h
│  │  │  │  ├── common
│  │  │  │  │  │ wpa_ctrl.h
│  │  │  │  ├── crypto
│  │  │  │  │  │ tls_mbedtls_alt.c
│  │  │  │  ├── drivers
│  │  │  │  │  ├── driver_zephyr.c
│  │  │  │  │  │ driver_zephyr.h
│  │  │  │  ├── utils
│  │  │  │  │  ├── includes.h
│  │  │  │  │  │ os_zephyr.c
│  │  │  ├── wpa_supplicant
│  │  │  │  ├── wpa_cli.c
│  │  │  │  ├── wpa_cli_cmds.c
│  │  │  │  ├── wpa_cli_zephyr.c
│  │  │  │  ├── wpa_cli_zephyr.h
│  │  │  │  ├── wpa_supplicant.c
│  │  │  │  │ wpa_supplicant_i.h
nrfxlib
│  ├── nrf_wifi
│  │  ├── bin
│  │  │  ├── ncs
│  │  │  │  ├── default
│  │  │  │  │  │ nrf70.bin
│  │  │  │  ├── offloaded_raw_tx
│  │  │  │  │  │ nrf70.bin
│  │  │  │  ├── radio_test
│  │  │  │  │  │ nrf70.bin
│  │  │  │  ├── scan_only
│  │  │  │  │  │ nrf70.bin
│  │  │  │  ├── system_with_raw
│  │  │  │  │  │ nrf70.bin
snippets
│  ├── wifi-p2p
│  │  ├── README.rst
│  │  ├── snippet.yml
│  │  │ wifi-p2p.conf
west.yml
zephyr
│  ├── drivers
│  │  ├── wifi
│  │  │  ├── nrf_wifi
│  │  │  │  ├── inc
│  │  │  │  │  │ wpa_supp_if.h
│  │  │  │  ├── src
│  │  │  │  │  ├── fmac_main.c
│  │  │  │  │  │ wpa_supp_if.c
│  ├── include
│  │  ├── zephyr
│  │  │  ├── net
│  │  │  │  │ wifi_mgmt.h
│  ├── modules
│  │  ├── hostap
│  │  │  ├── CMakeLists.txt
│  │  │  ├── Kconfig
│  │  │  ├── src
│  │  │  │  ├── supp_api.c
│  │  │  │  ├── supp_api.h
│  │  │  │  ├── supp_events.c
│  │  │  │  ├── supp_events.h
│  │  │  │  ├── supp_main.c
│  │  │  │  ├── supp_main.h
│  │  │  │  │ wpa_cli.c
│  ├── subsys
│  │  ├── net
│  │  │  ├── l2
│  │  │  │  ├── wifi
│  │  │  │  │  ├── wifi_mgmt.c
│  │  │  │  │  │ wifi_shell.c
│  │ west.yml

Outputs:

Toolchain

Version: df3cc9d822
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:df3cc9d822_e595b21c39

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ❌ Build twister
    • sdk-nrf test count: 911
    • sdk-zephyr test count: 686
  • ❌ Integration tests
    • ❌ test-fw-nrfconnect-chip
    • ❌ test-fw-nrfconnect-nfc
    • ❌ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ❌ test-fw-nrfconnect-nrf-iot_thingy91
    • ❌ test-fw-nrfconnect-rs
    • ❌ test-fw-nrfconnect-fem
    • ❌ test-fw-nrfconnect-thread-main
    • ❌ test-sdk-find-my
    • ❌ test-fw-nrfconnect-nrf_lrcs_positioning
    • ❌ test-sdk-wifi
    • ❌ test-low-level
    • ❌ test-sdk-dfu
    • ⚠️ test-fw-nrfconnect-nrf-iot_cloud
    • ⚠️ test-fw-nrfconnect-nrf_lrcs_mosh
    • ⚠️ test-fw-nrfconnect-nrf_lrcs_positioning
Disabled integration tests
    • desktop52_verification
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-tfm
    • test-sdk-audio
    • test-sdk-mcuboot
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@@ -0,0 +1,170 @@
.. _ug_wifi_direct:

Wi-Fi Direct (P2P mode)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should ideally be an upstream docs as this is not specific to nRF70.

CONFIG_WIFI_NM_WPA_SUPPLICANT_P2P=y
CONFIG_WPA_CLI=y
CONFIG_WIFI_NM_WPA_SUPPLICANT_LOG_LEVEL_INF=y
CONFIG_LTO=y
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment as to why this is needed.

Copilot AI review requested due to automatic review settings November 3, 2025 09:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@richabp
Copy link
Contributor

richabp commented Nov 3, 2025

There is no doc build, please check.

Copy link
Contributor

@richabp richabp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a Changelog entry for both the docs.

Comment on lines +3 to +4
Wi-Fi P2P Snippet (wifi-p2p)
##########################################
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Wi-Fi P2P Snippet (wifi-p2p)
##########################################
Wi-Fi P2P Snippet (wifi-p2p)
############################


Wi-Fi P2P Snippet (wifi-p2p)
##########################################

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some description.

Overview
********

This snippet enables Wi-Fi P2P support in supported networking samples.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything else to add?

Suggested change
This snippet enables Wi-Fi P2P support in supported networking samples.
This snippet enables Wi-Fi P2P support in supported networking samples.

Requirements
************

Hardware support for:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some intro text.

Suggested change
Hardware support for:
Hardware support for:

@rado17 rado17 requested a review from divyagona November 4, 2025 12:27
CONFIG_WIFI_NM_WPA_SUPPLICANT_P2P=y
CONFIG_WPA_CLI=y
CONFIG_WIFI_NM_WPA_SUPPLICANT_LOG_LEVEL_INF=y
CONFIG_LTO=y
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and why is this needed? Also why is the log level changed?

rado17 and others added 4 commits November 10, 2025 09:23
Pull Wi-Fi P2P support.

Signed-off-by: Ravi Dondaputi <ravi.dondaputi@nordicsemi.no>
Pull in changes done to support WPS connection and allowing
probe request to be sent to supplicant.

Signed-off-by: Ravi Dondaputi <ravi.dondaputi@nordicsemi.no>
Create snippet for P2P build.

Signed-off-by: Ravi Dondaputi <ravi.dondaputi@nordicsemi.no>
Add Wi-Fi direct (p2p mode) document.

Signed-off-by: Kapil Bhatt <kapil.bhatt@nordicsemi.no>
Copilot AI review requested due to automatic review settings November 10, 2025 09:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions
Copy link

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-25346/nrf/protocols/wifi/index.html
https://ncsdoc.z6.web.core.windows.net/PR-25346/nrf/protocols/wifi/wifi_direct.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM doc-required PR must not be merged without tech writer approval. manifest manifest-nrfxlib manifest-zephyr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants