tests: lib: lte_lc_api: Enable missing subscriptions #25455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NordicBuilder
added
the
changelog-entry-required
There was a problem hiding this comment.
Pull Request Overview
This PR enables subscription configurations for modem sleep and TAU pre-warning notifications in the LTE LC API unit tests. These notification features were previously tested but their subscription configurations were not enabled in the test suite.
Key changes:
- Enabled
CONFIG_LTE_LC_MODEM_SLEEP_NOTIFICATIONSandCONFIG_LTE_LC_TAU_PRE_WARNING_NOTIFICATIONSin test configuration - Introduced
enable_notifications()helper function to consolidate notification setup mocking - Refactored multiple test cases to use the new helper function for cleaner test code
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/lib/lte_lc_api/prj.conf | Enabled modem sleep and TAU pre-warning notification subscription configurations |
| tests/lib/lte_lc_api/src/lte_lc_api_test.c | Added enable_notifications() helper and updated test cases to mock notification subscriptions conditionally |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: be9848341759a51759dcf20b4148c099f91fd6b3 more detailssdk-nrf:
Github labels
List of changed files detected by CI (3)Outputs:ToolchainVersion: df3cc9d822 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
trantanen
approved these changes
Nov 6, 2025
Enabled CONFIG_LTE_LC_MODEM_SLEEP_NOTIFICATIONS and CONFIG_LTE_LC_TAU_PRE_WARNING_NOTIFICATIONS in unit tests. The notifications were tested by the UT, but not the notification subscriptions. Signed-off-by: Tommi Kangas <tommi.kangas@nordicsemi.no>
tokangas
force-pushed
the
lte_lc_ut_enable_subscriptions
branch
from
9519eb0 to
be98483
Compare
tokangas
removed
the
changelog-entry-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled
CONFIG_LTE_LC_MODEM_SLEEP_NOTIFICATIONSandCONFIG_LTE_LC_TAU_PRE_WARNING_NOTIFICATIONSin unit tests. The notifications were tested by the UT, but not the notification subscriptions.