Skip to content

Conversation

@SebastianBoe
Copy link
Contributor

Remove the sdfw_services tag as there are no tests with these files.

Remove the sdfw_services tag as there are no tests with these files.

Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
Copilot AI review requested due to automatic review settings November 7, 2025 15:14
@NordicBuilder NordicBuilder requested a review from a team November 7, 2025 15:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes obsolete CI configuration entries for sdfw_services that reference non-existent paths in the codebase. The changes clean up test specifications and CI tag definitions related to the removed sdfw_services component.

  • Removed ci_tests_subsys_sdfw_services tag definition from CI tags configuration
  • Removed sdfw_services path references from test specification file

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
scripts/ci/tags.yaml Removed ci_tests_subsys_sdfw_services tag definition that referenced non-existent paths
.github/test-spec.yml Removed obsolete include/sdfw/sdfw_services/* and subsys/sdfw_services/**/* path patterns from CI-dfu-test configuration
Comments suppressed due to low confidence (1)

scripts/ci/tags.yaml:1407

  • The ci_samples_sdfw tag at line 1400-1414 still references nrf/subsys/sdfw_services/ at line 1407, but this path does not exist in the codebase and similar references are being removed in this PR. This orphaned reference should also be removed for consistency, unless the directory is expected to be restored in the future.
    - nrf/subsys/sdfw_services/

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 7, 2025

CI Information

To view the history of this post, click the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: bf6f8ad4cf7a77af623b277c8ad6e40101954e3a

more details

sdk-nrf:

PR head: bf6f8ad4cf7a77af623b277c8ad6e40101954e3a
merge base: 40aaea40b964dd5702c7a9ce13cbd37b086abc4a
target head (main): 3ff658e7f6ebbc3605b98d797ab7789814fee47d
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2)
.github
│  │ test-spec.yml
scripts
│  ├── ci
│  │  │ tags.yaml

Outputs:

Toolchain

Version: df3cc9d822
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:df3cc9d822_e595b21c39

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
  • ✅ Integration tests
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants