Skip to content

54L: Coex single domain #25488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

54L: Coex single domain #25488

wants to merge 3 commits into from
+12 −16

Conversation

@krish2718
Copy link
Contributor

@krish2718 krish2718 commented Nov 7, 2025

Coex fixes for 54L series, specifically LM20.

@krish2718
samples: wifi: coex: Limit IPC radio to 53/54H Series
6d99ef3 
Only these two have a separate NET/RAD core needing IPC.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
@krish2718
samples: wifi: coex: Remove not applicable ipc radio
d01a2d6 
ipc_radio is not applicable for 54L, so, drop the prefixes as its a
single image.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
@krish2718
boards: shields: nrf7002eb2: Fix co-existence overlay
3a600df 
The board overrides the main overlay, so, coex was ending as disabled
even when coex shield variant is used.

Move the coex definition to the coex overlay directly.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Copilot AI review requested due to automatic review settings November 7, 2025 16:50
@NordicBuilder NordicBuilder added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 7, 2025
Copilot AI reviewed Nov 7, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the coexistence shield configuration for nRF7002EB2 by consolidating the coex device tree node definition and modernizing the shield configuration approach.

Key Changes:

  • Consolidates coex device tree node definition from base shield to coex overlay file
  • Updates sample.yaml files to use multi-shield syntax for coex configurations
  • Adds SOC series dependencies to IPC_RADIO configuration in Kconfig.sysbuild files

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
samples/wifi/thread_coex/sample.yaml Updates shield specification to use multi-shield syntax ("nrf7002eb2;nrf7002eb2_coex") and removes ipc_radio-specific CONFIG_MPSL_CX setting
samples/wifi/thread_coex/Kconfig.sysbuild Adds SOC series dependency (NRF53X/NRF54X) for NRF_DEFAULT_IPC_RADIO configuration
samples/wifi/ble_coex/sample.yaml Updates shield specification to use multi-shield syntax and removes ipc_radio-specific CONFIG_MPSL_CX setting
samples/wifi/ble_coex/Kconfig.sysbuild Adds SOC series dependency (NRF534X/NRF54HX) for NRF_DEFAULT_IPC_RADIO configuration
boards/shields/nrf7002eb2/nrf7002eb2_gpio_pins_2.dtsi Removes coex device tree node definition (moved to overlay file)
boards/shields/nrf7002eb2/nrf7002eb2_coex.overlay Fully defines coex device tree node instead of just enabling status (consolidation)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

samples/wifi/ble_coex/Kconfig.sysbuild
source "share/sysbuild/Kconfig"

config NRF_DEFAULT_IPC_RADIO
depends on SOC_SERIES_NRF534X || SOC_SERIES_NRF54HX
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SOC series symbol SOC_SERIES_NRF534X appears to be incorrect. Based on the codebase patterns, it should be SOC_SERIES_NRF53X to match the nRF53 series devices. The "4" in NRF534X appears to be a typo. The correct pattern is SOC_SERIES_NRF53X (for nRF53 series) and SOC_SERIES_NRF54LX or SOC_SERIES_NRF54HX (for nRF54 series).

Suggested change
depends on SOC_SERIES_NRF534X || SOC_SERIES_NRF54HX
depends on SOC_SERIES_NRF53X || SOC_SERIES_NRF54HX

Copilot uses AI. Check for mistakes.
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 7, 2025 •
edited
Loading

CI Information

To view the history of this post, click the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: 3a600df634ab5dfbbab214966914d9b6fa4636d0

more details

sdk-nrf:

PR head: 3a600df634ab5dfbbab214966914d9b6fa4636d0
merge base: cc348c5e87b4d87def7a8b28f24f12b47160cd96
target head (main): 3ebbdb07ae0b3ef3835acf0413da40896f4c2820
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (6) 
boards
│  ├── shields
│  │  ├── nrf7002eb2
│  │  │  ├── nrf7002eb2_coex.overlay
│  │  │  │ nrf7002eb2_gpio_pins_2.dtsi
samples
│  ├── wifi
│  │  ├── ble_coex
│  │  │  ├── Kconfig.sysbuild
│  │  │  │ sample.yaml
│  │  ├── thread_coex
│  │  │  ├── Kconfig.sysbuild
│  │  │  │ sample.yaml

Outputs:

Toolchain

Version: df3cc9d822
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:df3cc9d822_e595b21c39

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 196
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-sdk-wifi
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

You can find the documentation preview for this PR here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@muraliThokala muraliThokala Awaiting requested review from muraliThokala muraliThokala is a code owner

@bama-nordic bama-nordic Awaiting requested review from bama-nordic bama-nordic is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@krish2718 @NordicBuilder