Skip to content

fix: disable subject case rule #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

lersveen
Copy link
Contributor

Disable strict subject casing to be closer to the official conventional commits specification.

Closes #131.

@lersveen lersveen added the bug Something isn't working label Jul 30, 2024
@lersveen lersveen requested a review from a team as a code owner July 30, 2024 07:30
@lersveen lersveen requested review from martinsolberg, mikkel3000 and GrimburTheGit and removed request for a team July 30, 2024 07:30
@mikkel3000 mikkel3000 removed their request for review July 30, 2024 08:09
Disable strict subject casing to be closer to the official conventional commits specification.
@lersveen lersveen force-pushed the disable-subject-case-rule branch from f7aebab to 6de7a0f Compare August 14, 2024 10:50
@martinsolberg
Copy link
Contributor

@bateau84 André vil fjerne forced lowercase på commitmeldinger. Jeg er personlig ikke enig. Hva sier du?

@lersveen
Copy link
Contributor Author

lersveen commented Sep 2, 2024

Det er ikke kritisk, men skal man beholde det bør man i det minste dokumentere tydelig at implementasjonen ikke kun følger conventional commits, eller rett og slett gå over til å bruke @commitlint/config-angular.

@bateau84
Copy link
Contributor

bateau84 commented Sep 5, 2024

Dette får gå på høring med resten av @nrkno/plattform
Jeg har ingen mening om dette.

@bateau84 bateau84 removed their request for review September 9, 2024 10:00
Copy link
Contributor

@stigok stigok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeg støtter dette veldig. At jeg ikke kan skrive f.eks. "RFP", "API" eller "HTTP" midt i headeren gir ingen mening for meg.

@lersveen
Copy link
Contributor Author

Fixed signed commit in #142, closing this.

@lersveen lersveen closed this Sep 18, 2024
@lersveen lersveen deleted the disable-subject-case-rule branch September 18, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Valid conventional commits treated as invalid
4 participants