Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML-Render support from Package Manager #1247

Merged
merged 8 commits into from
Aug 27, 2024

Conversation

nytamin
Copy link
Contributor

@nytamin nytamin commented Aug 21, 2024

About the Contributor

This pull request is posted on behalf of the NRK

Type of Contribution

This is a:

Types update

New Behavior

Added types from Package Manager nrkno/sofie-package-manager#193

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

This PR only affects types

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@nytamin nytamin requested a review from a team as a code owner August 21, 2024 08:28
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 51.76768% with 191 lines in your changes missing coverage. Please review.

Project coverage is 57.94%. Comparing base (8712e51) to head (d90c220).
Report is 520 commits behind head on release51.

Files Patch % Lines
meteor/client/lib/viewPort.ts 0.00% 28 Missing ⚠️
meteor/client/lib/shelf.ts 0.00% 24 Missing ⚠️
.../client/ui/SegmentContainer/withResolvedSegment.ts 0.00% 23 Missing ⚠️
meteor/client/ui/Prompter/prompter.ts 0.00% 19 Missing ⚠️
...eor/client/ui/Prompter/controller/joycon-device.ts 0.00% 13 Missing ⚠️
meteor/client/lib/dev.ts 0.00% 10 Missing ⚠️
meteor/client/lib/rundownLayouts.ts 0.00% 10 Missing ⚠️
meteor/client/lib/ui/pieceUiClassNames.ts 0.00% 9 Missing ⚠️
...r/client/ui/Prompter/controller/keyboard-device.ts 0.00% 9 Missing ⚠️
meteor/client/lib/rundown.ts 84.09% 7 Missing ⚠️
... and 15 more
Additional details and impacted files
@@              Coverage Diff              @@
##           release51    #1247      +/-   ##
=============================================
- Coverage      57.95%   57.94%   -0.01%     
=============================================
  Files            485      525      +40     
  Lines          79860    84832    +4972     
  Branches        3547     4374     +827     
=============================================
+ Hits           46280    49158    +2878     
- Misses         33543    35649    +2106     
+ Partials          37       25      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…:nrkno/sofie-core into fix/pm-types-html-template

# Conflicts:
#	meteor/lib/collections/ExpectedPackages.ts
#	packages/shared-lib/src/package-manager/package.ts
@nytamin nytamin changed the title chore: sync package.ts file with Package Manager Add HTML-Render support from Package Manager Aug 23, 2024
@nytamin nytamin merged commit 81d8e77 into release51 Aug 27, 2024
94 of 96 checks passed
@nytamin nytamin deleted the fix/pm-types-html-template branch August 27, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants