Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Studio migrations (SOFIE-3798) #1383

Open
wants to merge 1 commit into
base: release52
Choose a base branch
from

Conversation

jstarpl
Copy link
Member

@jstarpl jstarpl commented Feb 12, 2025

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a:

Bug fix

Current Behavior

Studio settings are migrated as defaults instead of overrides, unlike the other properties (like routeSets).

New Behavior

Studio settings are migrated as overrides, since they are manually entered.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

Time Frame

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@jstarpl jstarpl requested a review from a team as a code owner February 12, 2025 12:11
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 56.26%. Comparing base (33514b1) to head (dbc3bca).
Report is 59 commits behind head on release52.

Files with missing lines Patch % Lines
meteor/server/migration/1_52_0.ts 16.66% 5 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release52    #1383      +/-   ##
=============================================
- Coverage      56.38%   56.26%   -0.13%     
=============================================
  Files            406      408       +2     
  Lines          72655    73121     +466     
  Branches        4602     4616      +14     
=============================================
+ Hits           40967    41140     +173     
- Misses         31469    31728     +259     
- Partials         219      253      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants