Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes around responses with no children #40

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Various fixes around responses with no children #40

merged 5 commits into from
Sep 20, 2024

Conversation

mint-dewit
Copy link

Type of Contribution

Bug fix

Current Behavior

  • Calling getDirectory on the root of the tree more than once causes a timeout
  • Calling getDirectory on parameters(?) or empty nodes fails because we expect children to be returned
  • Empty nodes are sent out by the provider with all parameters set which is against the spec

New Behavior

  • Can call getDirectory on the root multiple times
  • Can call getDirectory on parameters and empty nodes
  • Empty nodes are sent out by the provider with all parameters removed as in line with the ember+ documentation

@mint-dewit mint-dewit requested a review from a team September 11, 2024 13:00
@mint-dewit mint-dewit mentioned this pull request Sep 11, 2024
Closed
@mint-dewit mint-dewit mentioned this pull request Sep 11, 2024
Closed
@nytamin nytamin merged commit 24129fa into master Sep 20, 2024
16 checks passed
@nytamin nytamin deleted the fix/empty-responses branch September 25, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nytamin nytamin nytamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mint-dewit @nytamin