fix: NRCS returns empty objects

[olzzon]

About the Contributor

This pull request is posted on behalf of BBC

Type of Contribution

This is a:

Bug fix

Current Behavior

If the NRCS has empty or missing objects in the MachineInfo, the mos-connection will return an error, also in non strict mode.

New Behavior

When in non strict mode, mos-connection will fill out empty empty objects, and handle xmlSupportedProfiles as optional if it's undefined.

Testing Instructions

Run the MOS gateway with OpenMedia, and it will crash with the old version of mos-connection.

Other Information

Status

• [ x] PR is ready to be reviewed.
• [ x] The functionality has been tested by the author.
• Relevant unit tests has been added / updated.
• Relevant documentation (code comments, system documentation) has been added / updated.

[jstarpl]

Generally approving as okay, but I have a code style comment.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 77.43%. Comparing base (f996003) to head (9bb6825).

Files	Patch %	Lines
...ages/helper/src/mosModel/profile0/xmlConversion.ts	0.00%	0 Missing and 1 partial ⚠️
packages/model/src/mosTypes/mosTime.ts	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   77.39%   77.43%   +0.04%     
==========================================
  Files          65       65              
  Lines        3570     3572       +2     
  Branches      804      823      +19     
==========================================
+ Hits         2763     2766       +3     
+ Misses        783      747      -36     
- Partials       24       59      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.