Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NORA Core Device (SOFIE-1377) #239

Draft
wants to merge 11 commits into
base: release48
Choose a base branch
from
Draft

Conversation

jstarpl
Copy link
Member

@jstarpl jstarpl commented Feb 7, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

This implements a bespoke NORA Core device.

  • Other information:

@jstarpl jstarpl requested a review from Julusian February 7, 2023 11:59
@jstarpl jstarpl changed the base branch from master to release48 February 7, 2023 12:00
@jstarpl jstarpl changed the base branch from release48 to release47 February 7, 2023 12:00
@jstarpl jstarpl changed the base branch from release47 to release48 February 7, 2023 12:00
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Base: 30.24% // Head: 29.81% // Decreases project coverage by -0.43% ⚠️

Coverage data is based on head (58b0c83) compared to base (9a43f95).
Patch coverage: 2.85% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@              Coverage Diff              @@
##           release48     #239      +/-   ##
=============================================
- Coverage      30.24%   29.81%   -0.43%     
=============================================
  Files             58       59       +1     
  Lines           8548     8688     +140     
  Branches        2159     2186      +27     
=============================================
+ Hits            2585     2590       +5     
- Misses          5436     5563     +127     
- Partials         527      535       +8     
Impacted Files Coverage Δ
...ckages/timeline-state-resolver-types/src/device.ts 100.00% <ø> (ø)
...e-state-resolver/src/integrations/noraNRK/index.ts 0.00% <0.00%> (ø)
...ackages/timeline-state-resolver-types/src/index.ts 100.00% <100.00%> (ø)
packages/timeline-state-resolver/src/conductor.ts 81.32% <100.00%> (+0.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jstarpl jstarpl requested a review from nytamin February 8, 2023 10:01
export interface TimelineObjNoraNRKBase extends TSRTimelineObjBase {
content: {
deviceType: DeviceType.NORA_NRK
// type: TimelineContentTypeCasparCg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have a type field here. This is something that becomes required with the json schemas in r49

Copy link
Contributor

@nytamin nytamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes after a talk with Jan:

The idea of this initial implementation is to have feature-parity with the old httpSend device. As such, I think this is a good-enough implementation :)

We also talked about the next step where the device would be listening to the actual state of Nora, and I also think that is a good implementation plan.

@jstarpl
Copy link
Member Author

jstarpl commented Mar 7, 2023

Since the use case for this PR has been resolved in another way, the decision has been made to mothball this PR as a draft.

@jstarpl jstarpl marked this pull request as draft March 7, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants