-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: NORA Core Device (SOFIE-1377) #239
base: release48
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 30.24% // Head: 29.81% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## release48 #239 +/- ##
=============================================
- Coverage 30.24% 29.81% -0.43%
=============================================
Files 58 59 +1
Lines 8548 8688 +140
Branches 2159 2186 +27
=============================================
+ Hits 2585 2590 +5
- Misses 5436 5563 +127
- Partials 527 535 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
export interface TimelineObjNoraNRKBase extends TSRTimelineObjBase { | ||
content: { | ||
deviceType: DeviceType.NORA_NRK | ||
// type: TimelineContentTypeCasparCg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to have a type field here. This is something that becomes required with the json schemas in r49
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notes after a talk with Jan:
The idea of this initial implementation is to have feature-parity with the old httpSend device. As such, I think this is a good-enough implementation :)
We also talked about the next step where the device would be listening to the actual state of Nora, and I also think that is a good implementation plan.
Since the use case for this PR has been resolved in another way, the decision has been made to mothball this PR as a draft. |
Feature
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
This implements a bespoke NORA Core device.