feat: atem command batching SOFIE-2549 #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julusian
force-pushed
the
feat/atem-command-batching
branch
from
83c66c8 to
6eb070c
Compare
nytamin
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by nrkno/sofie-atem-connection#157
feature
Commands are sent to an ATEM one at a time, one per packet.
For each state in time, the commands will be sent to the atem as a single batch (or packed into as few packets as possible).
This will help with responsiveness, as there is a limited number of packets allowed to be in flight at once, and it is not uncommon for 10+ commands to have the same start time.