Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suppress quantel disconnect shortly #314

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

mint-dewit
Copy link
Contributor

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: fix / improvement

Current Behavior

When the connection to the ISA is lost a connection error is immediately emitted.

New Behavior

When the connection to the ISA is lost the connection error will be suppressed momentarily. This allows it to fail over to a backup isa quietly.

Testing Instructions

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@mint-dewit mint-dewit requested a review from a team December 14, 2023 12:15
Copy link
Contributor

@nytamin nytamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I would probably add something about "recommended value: 1000 ms" to the descriptions, that might be helpful to users.

@mint-dewit mint-dewit merged commit a238f67 into release51 Dec 14, 2023
36 checks passed
@Julusian Julusian deleted the SOFIE-2686-suppress-quantel-disconnect branch June 27, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants