Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viz reset action (Sofie 2830) #323

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Conversation

mint-dewit
Copy link
Contributor

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: Feature

Bug fix / Feature / Code improvement / Documentation improvement / Other (please specify)

New Behavior

An action trigger will perform a combination-macro of Clear Engine and Purge and Activation command for Viz

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@mint-dewit mint-dewit requested a review from a team March 5, 2024 14:26
Copy link
Member

@jstarpl jstarpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, but I'm not sure if the "Optional property" of "Rundown playlist ID" is described well enough that what it's supposed to be used for isn't forgotten in 2 years.

"properties": {
"activeRundownPlaylistId": {
"name": "Rundown playlist ID",
"description": "Optional property",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be better described maybe? Is this the Rundown Playlist ID in Sofie, or some internal Viz ID?

@mint-dewit mint-dewit merged commit b8d20fa into release50 Mar 22, 2024
33 checks passed
@Julusian Julusian deleted the SOFIE-2830-viz-reset-action branch June 27, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants