Update release51 with fixes from release50 #332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the data length that vMix provides is in bytes, not chars; the line remainder has to be stored as a buffer in case the arriving data is fragmented mid-character
* chore: add reset action for viz reset * chore: add rundownId to viz reset aciton * chore: viz reset action also resets state * chore: better description
After learning what setEncoding does, parts of the previous commit are reverted and the rest of the code is updated to make use of the fact that the 'data' event supplies a string
…ngth fix(vMix): handling XML messages with multi-byte characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
Type of Contribution
This is a:
Bug fix / Feature / Code improvement / Documentation improvement / Other (please specify)
Current Behavior
New Behavior
Testing Instructions
Other Information
Status