Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: viz and quantel callback leak #344

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Conversation

Julusian
Copy link
Contributor

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: Bug fix

Current Behavior

viz and quantel use a similar flow of waiting and being able to satisfy those waits.
queued callbacks were never being cleared once called, resulting in them being gradually leaked

New Behavior

this has been refactored to share a common implementation, with the new implementation cleaning up the callbacks as they are called.

Testing Instructions

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@Julusian Julusian requested a review from a team as a code owner August 23, 2024 16:23
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 57.22%. Comparing base (6fef9f7) to head (e0bcfee).
Report is 1 commits behind head on release52.

Files Patch % Lines
packages/timeline-state-resolver/src/waitGroup.ts 13.63% 17 Missing and 2 partials ⚠️
...-resolver/src/integrations/vizMSE/vizMSEManager.ts 25.00% 3 Missing ⚠️
...te-resolver/src/integrations/quantel/connection.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release52     #344      +/-   ##
=============================================
+ Coverage      55.77%   57.22%   +1.44%     
=============================================
  Files            129      130       +1     
  Lines          10130    10533     +403     
  Branches        2524     2630     +106     
=============================================
+ Hits            5650     6027     +377     
- Misses          4103     4134      +31     
+ Partials         377      372       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian
Copy link
Contributor Author

Putting this on hold for now, as both implementations of clearAllWait* were no-ops prior to this, due to bugs in their implementations.

@Julusian Julusian marked this pull request as draft August 26, 2024 13:35
@Julusian Julusian marked this pull request as ready for review August 27, 2024 08:58
@Julusian Julusian merged commit 29ad13d into release52 Aug 27, 2024
36 checks passed
@Julusian Julusian deleted the fix/viz-quantel-callback-leak branch August 27, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants