Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor vizmse device to state handler SOFIE-2498 #347

Draft
wants to merge 6 commits into
base: release52
Choose a base branch
from

Conversation

Julusian
Copy link
Member

The unit tests are not fully updated to the new format, so are failing.
The implementation has not been tested yet, due to lack of direct access to a viz engine/mse.

About the Contributor

Type of Contribution

This is a:

Bug fix / Feature / Code improvement / Documentation improvement / Other (please specify)

Current Behavior

New Behavior

Testing Instructions

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 13.51351% with 224 lines in your changes missing coverage. Please review.

Project coverage is 61.46%. Comparing base (517f0ee) to head (e161966).

Files with missing lines Patch % Lines
...tate-resolver/src/integrations/vizMSE/diffState.ts 7.33% 101 Missing ⚠️
...e-resolver/src/integrations/vizMSE/convertState.ts 5.55% 68 Missing ⚠️
...ne-state-resolver/src/integrations/vizMSE/index.ts 31.25% 44 Missing ⚠️
...eline-state-resolver/src/service/DeviceInstance.ts 0.00% 6 Missing ⚠️
...-resolver/src/integrations/vizMSE/vizMSEManager.ts 0.00% 2 Missing ⚠️
...ges/timeline-state-resolver/src/service/devices.ts 33.33% 2 Missing ⚠️
...ages/timeline-state-resolver/src/service/device.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release52     #347      +/-   ##
=============================================
+ Coverage      56.75%   61.46%   +4.71%     
=============================================
  Files            130      132       +2     
  Lines          10111    10073      -38     
  Branches        2459     2370      -89     
=============================================
+ Hits            5738     6191     +453     
+ Misses          4371     3880     -491     
  Partials           2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian Julusian changed the title wip: refactor chore: refactor vizmse device to state handler SOFIE-2498 Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants