Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error spawn einval #361

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

nytamin
Copy link
Contributor

@nytamin nytamin commented Nov 28, 2024

To fix a build error ("spawn EINVAL")

About the Contributor

This pull request is posted on behalf of the NRK

Type of Contribution

This is a: Bug fix

Current Behavior

Using Node.js 18.20.4 on Windows, installing dependencies (yarn install) fails due to:

utf-8-validate@npm:6.0.4 couldn't be built successfully (exit code 1)
[...]
Error: spawn EINVAL
    at ChildProcess.spawn (node:internal/child_process:414:11)
    at Object.spawn (node:child_process:761:9)
    at build (tsr\node_modules\node-gyp-build\bin.js:29:8)

This is due to a security patch released to all Node.js versions: nodejs/node#52554 (comment)

New Behavior

Installation works.

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@nytamin nytamin requested a review from a team as a code owner November 28, 2024 09:07
To fix a build error ("spawn EINVAL")
@nytamin nytamin force-pushed the chore/fix-build-error-spawn-einval branch from f231aa8 to dc8082b Compare November 28, 2024 09:16
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.86%. Comparing base (ad41ae6) to head (dc8082b).

Additional details and impacted files
@@            Coverage Diff             @@
##           release52     #361   +/-   ##
==========================================
  Coverage      56.86%   56.86%           
==========================================
  Files            131      131           
  Lines          10293    10293           
  Branches        2575     2566    -9     
==========================================
  Hits            5853     5853           
  Misses          4074     4074           
  Partials         366      366           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nytamin nytamin merged commit 8239202 into release52 Nov 28, 2024
36 checks passed
@nytamin nytamin deleted the chore/fix-build-error-spawn-einval branch November 28, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants