Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EAV-423): add actions to start and stop External in vMix #362

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

ianshade
Copy link
Contributor

@ianshade ianshade commented Dec 6, 2024

About the Contributor

This pull request is posted on behalf of TV 2 Norge

Type of Contribution

This is a:

Feature

Current Behavior

No TSR actions to start/stop External output in vMix

New Behavior

TSR actions to start/stop External output in vMix are added.
Note: Those actions are not taking the External mapping and timeline objects into consideration. To avoid undefined behavior, either use the timeline or the actions to control the External output, not both.

Testing Instructions

When used with Sofie, it can be tested using the autogenerated buttons in the Playout Gateway section of Sofie settings.
Press Start External and verify if the External indicator lit up red in vMix.
Press Stop External and verify if the External indicator went back to grey in vMix.

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@ianshade ianshade requested a review from a team as a code owner December 6, 2024 22:39
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 13.04348% with 20 lines in your changes missing coverage. Please review.

Project coverage is 57.33%. Comparing base (ad41ae6) to head (e002d0f).
Report is 16 commits behind head on release52.

Files with missing lines Patch % Lines
...line-state-resolver/src/integrations/vmix/index.ts 0.00% 16 Missing and 4 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release52     #362      +/-   ##
=============================================
+ Coverage      56.86%   57.33%   +0.46%     
=============================================
  Files            131      160      +29     
  Lines          10293    10947     +654     
  Branches        2575     2668      +93     
=============================================
+ Hits            5853     6276     +423     
- Misses          4074     4286     +212     
- Partials         366      385      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jstarpl jstarpl merged commit a7369c9 into nrkno:release52 Dec 9, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants