-
Notifications
You must be signed in to change notification settings - Fork 2.6k
chore(repo): split slow e2e tests - web, webpack, and workspace-create #33011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Split the following test suites into smaller, more focused tests: - web tests (decorator babel/swc, env variables, generate, html interpolation, new format, vite) - webpack tests (app plugin, assets, babel, compose plugins, config variations, env variables, executor options, node compilers) - workspace-create npm tests (angular, express, init, js, nest, next, node, react-native, react, web)
The latest updates on your projects. Learn more about Vercel for GitHub.
|
View your CI Pipeline Execution ↗ for commit 02b9a15
☁️ Nx Cloud last updated this comment at |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
2e9c905
to
979802a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud is proposing a fix for your failed CI:
We've identified and fixed the missing dependency issue in the webpack compose plugins test. The test was using withReact()
from @nx/react
but wasn't installing that package during setup. Adding @nx/react
to the setupWebpackTest()
packages list resolves the "Cannot find module '@nx/react'" error.
We could not verify this fix.
diff --git a/e2e/webpack/src/webpack-compose-plugins.test.ts b/e2e/webpack/src/webpack-compose-plugins.test.ts
index 017bf390ab..543032e99f 100644
--- a/e2e/webpack/src/webpack-compose-plugins.test.ts
+++ b/e2e/webpack/src/webpack-compose-plugins.test.ts
@@ -2,7 +2,7 @@ import { runCLI, uniq, updateFile } from '@nx/e2e-utils';
import { setupWebpackTest } from './webpack-setup';
describe('Webpack Plugin', () => {
- setupWebpackTest(['@nx/web', '@nx/webpack']);
+ setupWebpackTest(['@nx/web', '@nx/webpack', '@nx/react']);
it('should be able to support webpack config with nx enhanced and babel', () => {
const appName = uniq('app');
Or Apply changes locally with:
npx nx-cloud apply-locally JxS2-QyOP
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 To learn more about Self Healing CI, please visit nx.dev
Split the following test suites into smaller, more focused tests:
Fixes CLOUD-3756
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #