-
Notifications
You must be signed in to change notification settings - Fork 2.6k
chore(repo): split slow e2e tests - ng-add, cypress, eslint linter, a… #33012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…nd affected-graph Split the following test suites into smaller, more focused tests: - ng-add tests (cypress v9/v10, eslint, generate workspace, multiple projects) - cypress tests (component testing for Angular and Next, e2e execution, app generation) - eslint linter tests (dependency checks, flat config, linting errors, module boundaries, root configs) - affected-graph tests (affected star, focus/exclude, html/json output, show projects, git integration)
The latest updates on your projects. Learn more about Vercel for GitHub.
|
View your CI Pipeline Execution ↗ for commit 8c1461b
☁️ Nx Cloud last updated this comment at |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud has identified a possible root cause for your failed CI:
The failure is classified as 'flaky_task' because the test suite was split from a large monolithic file into separate files, which changed the test execution context and timing. The specific failing test "should not affect other projects by generating a new project" relies on git state and affected project calculations, which are inherently timing-sensitive in e2e tests.
The actual test logic remains identical to the original implementation - it checks that generating a new library doesn't incorrectly mark previously committed apps as affected. No direct code changes were made to this specific test.
Git-based affected calculations in e2e tests are sensitive to file system operation timing, git index state, and test execution order. By splitting the tests into separate files, the execution context changed, which exposed a race condition or state management issue that wasn't visible in the original monolithic test structure.
The failure shows no signs of network errors, resource exhaustion, or external service issues. Additionally, the 'mcp__utilities__similar_task_failure_outputs' tool returned no output from the master branch, suggesting this test either passes in master or the timing issue is specific to the new isolated execution context.
While one related test in the same file had a fix added ('git add .' before commit in the "should detect changes to implicitly dependant projects" test), the failing test itself was not modified, further indicating the issue stems from test isolation rather than intentional logic changes.
A code change would likely not resolve this issue, so no action was taken.
🎓 To learn more about Self Healing CI, please visit nx.dev
…nd affected-graph
Split the following test suites into smaller, more focused tests:
Fixes CLOUD-3756
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #