Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new redirect APIs #307

Merged
merged 24 commits into from
Jun 18, 2024
Merged

Add new redirect APIs #307

merged 24 commits into from
Jun 18, 2024

Conversation

fformica
Copy link
Contributor

Adding objects representing redirect configs and certs

@fformica fformica marked this pull request as ready for review March 7, 2024 16:37
@fformica
Copy link
Contributor Author

fformica commented Jun 6, 2024 •
edited
Loading

Um, this morning we deployed a gRPC change so I'll have to align ns1-go 😓
EDIT: nevermind, ns1-go uses the APIs, not gRPC, and it tests correctly, so that's not the reason why I see the same problem with tags in terraform as we had in gRPC
EDIT: fixed

@fformica fformica merged commit b06bab5 into ns1-terraform:master Jun 18, 2024
2 checks passed
@AlejandroTrev AlejandroTrev mentioned this pull request Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pburrows-ns1 pburrows-ns1 pburrows-ns1 approved these changes

@Zach-Johnson Zach-Johnson Awaiting requested review from Zach-Johnson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fformica @pburrows-ns1