Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mimics the
--dns01-recursive-nameservers
flag in cert-manager for split DNS.Currently if you have an internal DNS server that responds with SOAs for zones that do not exist in NS1, you get errors such as:
This appears to be because of how util.FindZoneByFqdn works. Being able to specify external nameservers fixes this issue.
Another solution would be to have this webhook query the NS1 api for zones and compare, but I opted for this as it keeps it in line with how cert-manager works.