Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for listing account activity #233

Merged
merged 4 commits into from
Apr 18, 2024

Commits on Apr 4, 2024

  1. feat: add support for listing account activity

    This adds a new service to enable listing NS1 account activity. The
    endpoint supports many url parameters to adjust response behavior (such
    as changing/limiting how many activity entries are returned, etc), but
    for this initial approach, the sdk just uses the endpoint directly with
    the endpoint's normal default values.
    
    I used a small Terraform config to generate 50 dummy DNS records on my
    NS1 account to generate some account activity and have confirmed that
    the endpoint operates as expected -- the values I expected are returned,
    the response is limited to the last 20 activity entries like the
    endpoint default, etc.
    
    Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>
    tjhop committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    5ed1f9e View commit details
    Browse the repository at this point in the history
  2. feat: add optional url param support to account activity List()

    Depends on ns1#234
    
    Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>
    tjhop committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    b3ae27e View commit details
    Browse the repository at this point in the history
  3. test: add test for account activity endpoint

    Depends on ns1#234
    
    Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>
    tjhop committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    3f841e0 View commit details
    Browse the repository at this point in the history
  4. test: add account activity test with >1 param to suite

    Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>
    tjhop committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    5e39f52 View commit details
    Browse the repository at this point in the history