Add support for the v1beta1 alerts api. #244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add code to call api. - Add testcases. - Add example.
| @@ -0,0 +1,46 @@ | |||
| package alerting | |||
There was a problem hiding this comment.
oh nice, more models! its not like that we did not have enough already :D
There was a problem hiding this comment.
not a jab at the PR but rather than the fact that we have a 1000 models!
apantelopoulosNS1
approved these changes
Oct 29, 2024
| var client *api.Client | ||
|
|
||
| // Helper that initializes rest api client from environment variable. | ||
| func init() { |
There was a problem hiding this comment.
Is this called in the example somewhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the alerts api.