Skip to content

[#1003] Migrate Policy Settings JSP To Thymeleaf #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: v3.1_jsp-2-thymeleaf-migration
Choose a base branch
from
Draft

[#1003] Migrate Policy Settings JSP To Thymeleaf #1043

wants to merge 5 commits into from

Conversation

@ThatSilentCoder
Copy link
Collaborator

Description

Migrate Policy Settings JSP Page To Thymeleaf.

Test Instructions

  1. Run the ACA using your preferred method and verify that the Policy Settings page behaves as expected.
  2. Verify that you can enable and disable endorsement credential validation without any issues.
  3. Verify that you can enable and disable platform credential validation without any issues.
  4. Verify that you can enable and disable platform attribute validation without any issues.
  5. Verify that you can enable and disable attestation certificate generation without any issues.
  6. Verify that you can enable and disable ldevid certificate generation without any issues.
  7. Verify that you can enable and disable firmware validation without any issues.
  8. Verify that you can enable and disable protobuf logging for different situations without any issues.

Issues This PR Addresses:

Closes #1033

@ThatSilentCoder
v3.1_issue_1033: Started working on policy settings page.
d6db125
@ThatSilentCoder
v3.1_issue_1033: Started migrating pieces of the policy settings webs…
0d06153 
…ite over to thymeleaf. The styling looks off but the modal works fine. When submitting policy changes, it for some reason think its im trying to request another site and not a rest call.
@ThatSilentCoder
Merge branch 'v3.1_jsp-2-thymeleaf-migration' into v3.1_issue_1033-mi…
4a8a1ef 
…grate-policy-settings-jsp-page
@ThatSilentCoder
v3.1_issue_1033: Finished adding content to policy.htl page. Neeed to…
2e4e0b7 
… figure out why side nav bar isnt extending all the way to the bottom of the page and need to figure out why content inside modal is appearing right below li elements
@ThatSilentCoder
v3.1_issue_1033: Can make rest calls now and the entire page is compl…
5be63a4 
…ete. Cannot make rest calls for protobuf. Need to figure out hidden div issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ThatSilentCoder