-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Themes and playing media icon. issue #38 #40
Conversation
React admin and basic theming
4df4baf
to
5297b5d
Compare
Thanks for all the hard work on this, @shapkarin . I should have some time to look at the PR over the weekend. |
@nsand OK, feel free to share yours thoughts |
e7059c9
to
9b2f860
Compare
ping |
Hey, @shapkarin Sorry work has been crazy lately and some RL things have popped up on top of that. I'll try reviewing this soon. |
Got that. Thanks for the answer. Maybe I will add tests to this repo later. |
Thanks for considering perf in this! I’ll have some time this weekend to take a look. |
Hey, @shapkarin. I started looking at the changes and things are looking good so far. I haven't worked with styled-components yet, so I'm going to brush up on them a bit before continuing on. But just wanted to thank you for your patience while I review this. |
It looks like it's just a higher-order component. But I still think that we need to add something like |
I will try to find time for #39 too.. and fell free to help me with that |
Hello. It's about half of year I use my fork and don't get any problems with performance. I guess that my PR is fine. |
Thanks @shapkarin . I'm so sorry for this taking so long to get merged in. I appreciate your persistence and contribution! I hope you're doing well and staying healthy. |
thanks |
#38