-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: add --msPerBlock
flag
#164
Conversation
a3e77c0
to
40a9983
Compare
--msPerBlock
flag
40a9983
to
867c5a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main question is: there are two steps during every benchmark run: the first is node configuration files generation from YAML templates, and the second is nodes start based on the generated configuration. MsPerBlock setting is added to both these steps. Have you ensured that these two settings are consistent? What happens if I'll specify different values at these two steps?
if you specify different value after |
eb8ca46
to
d771154
Compare
d771154
to
e576b9f
Compare
94c12d6
to
793d25a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic itself LGTM, minor style fixes are left.
793d25a
to
de5e36d
Compare
de5e36d
to
3e1caf5
Compare
--msPerBlock flag added to runner.sh and `msPerBlock` is used in generation config files. Close #161 Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
3e1caf5
to
924e1bb
Compare
./runner.sh --nodes mixed --rpc sharp -d "Mytest" -m rate -q 50 -z 5m -t 30s --time $(TIME_PER_BLOCK)
example: