Go 1.22 #150
Merged
Go 1.22 #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop 1.21 and use 1.23 for test and build. Closes #113. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #150 +/- ##
======================================
Coverage 3.03% 3.03%
======================================
Files 18 18
Lines 987 987
======================================
Hits 30 30
Misses 955 955
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Please update dependencies as well. Ubuntu is optional, it's not yet set in stone (nspcc-dev/.github#32)
Use `for range arr` instead of `for loop`. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Signed-off-by: Andrey Butusov <andrey@nspcc.io>
End-rey
force-pushed
the
113-go-122-upgrade
branch
from
275e062 to
3f84a08
Compare
smallhive
approved these changes
Aug 29, 2024
roman-khimov
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #113.
Is it also necessary to change here the ubuntu version to the latest in workflows?