Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add --relative-path option #3206

Merged
merged 1 commit into from
Nov 24, 2023
Merged

cli: add --relative-path option #3206

merged 1 commit into from
Nov 24, 2023

Conversation

AliceInHunterland
Copy link
Contributor

Closes #3179

@codecov Codecov
Copy link

codecov bot commented Nov 20, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (195bb74) 85.32% compared to head (f457d50) 85.32%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3206      +/-   ##
==========================================
- Coverage   85.32%   85.32%   -0.01%     
==========================================
  Files         326      326              
  Lines       43949    43967      +18     
==========================================
+ Hits        37498    37513      +15     
- Misses       4975     4977       +2     
- Partials     1476     1477       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnnaShaleva
Copy link
Member

Please, change the PR name to something like cli: add --relative-path option or Add --relative-path option to CLI. See the https://github.com/nspcc-dev/.github/blob/master/git.md#commit-messages, the same pattern can be applied to the PR names.

@AliceInHunterland AliceInHunterland changed the title relative-path: flag add to the cli cli: add --relative-path option Nov 20, 2023
AnnaShaleva
AnnaShaleva reviewed Nov 20, 2023
View reviewed changes
cli/options/options.go Show resolved Hide resolved
cli/options/options.go Outdated Show resolved Hide resolved
cli/options/options.go Outdated Show resolved Hide resolved
cli/server/server_test.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
cli/vm/vm.go Show resolved Hide resolved
AnnaShaleva
AnnaShaleva reviewed Nov 20, 2023
View reviewed changes
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, change the commit message. See the #3206 (comment), this comment is also relevant for the commit messages. And try to fit the message into one line (~69 characters at max).

@AliceInHunterland AliceInHunterland force-pushed the relative_path_flag branch 2 times, most recently from 35e10ee to 92719a4 Compare November 20, 2023 14:16
@AliceInHunterland AliceInHunterland marked this pull request as ready for review November 20, 2023 14:18
@roman-khimov
Copy link
Member

Needs a rebase after recent merges.

AnnaShaleva
AnnaShaleva reviewed Nov 21, 2023
View reviewed changes
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better.

cli/options/options.go Outdated Show resolved Hide resolved
cli/server/server_test.go Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/core/blockchain_neotest_test.go Outdated Show resolved Hide resolved
AnnaShaleva
AnnaShaleva reviewed Nov 22, 2023
View reviewed changes
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issues are left, otherwise LGTM.

cli/options/options.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
@AliceInHunterland AliceInHunterland force-pushed the relative_path_flag branch 2 times, most recently from bb13eed to a77e804 Compare November 23, 2023 07:48
AnnaShaleva
AnnaShaleva reviewed Nov 23, 2023
View reviewed changes
pkg/config/config.go Outdated Show resolved Hide resolved
cli/options/options.go Outdated Show resolved Hide resolved
AnnaShaleva
AnnaShaleva reviewed Nov 23, 2023
View reviewed changes
cli/options/options.go Outdated Show resolved Hide resolved
cli/vm/cli_test.go Outdated Show resolved Hide resolved
AnnaShaleva
AnnaShaleva reviewed Nov 23, 2023
View reviewed changes
cli/server/server_test.go Outdated Show resolved Hide resolved
cli/server/server_test.go Outdated Show resolved Hide resolved
@AliceInHunterland
cli: add --relative-path option
f457d50 
To be able running the node from any working directory by simply
pointing the relative-path as prefix for relative parameters set in
config.

Closes #3179.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AnnaShaleva
AnnaShaleva approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@AnnaShaleva AnnaShaleva merged commit 5d1e019 into master Nov 24, 2023
16 of 18 checks passed
@AnnaShaleva AnnaShaleva deleted the relative_path_flag branch November 24, 2023 05:16
@AnnaShaleva AnnaShaleva mentioned this pull request Feb 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaShaleva AnnaShaleva AnnaShaleva approved these changes

@roman-khimov roman-khimov roman-khimov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UnlockWallet relative to config instead of node execution dir
3 participants
@AliceInHunterland @AnnaShaleva @roman-khimov