Introduce stackitem serialization limits #3218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaShaleva
force-pushed
the
serialization-limits
branch
from
9107ef1 to
6d788cd
Compare
Follow the notion of neo-project/neo#2948. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Port the restrictive part of neo-project/neo#2948. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
This reverts commit 822722b. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
serialization-limits
branch
from
6d788cd to
1d189fd
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3218 +/- ##
==========================================
+ Coverage 85.32% 85.36% +0.03%
==========================================
Files 326 326
Lines 43884 43945 +61
==========================================
+ Hits 37445 37512 +67
+ Misses 4955 4951 -4
+ Partials 1484 1482 -2 ☔ View full report in Codecov by Sentry. |
Manifest will be a part of the state.Contract which will be checked on its way to the storage. Tiny optimisation which allows not to serialize manifest twice. Ref. #3218 (comment). Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
roman-khimov
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3197.
Draft until the following TODOs are done:
Port deserialisation changes from Validate serialization during Contract deploy and Update neo-project/neo#2948Adjust IInteroperable serialization limits.