Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anti-DOS RPC limitations #3221

Merged
merged 4 commits into from
Nov 23, 2023
Merged

Anti-DOS RPC limitations #3221

merged 4 commits into from
Nov 23, 2023

Conversation

AnnaShaleva
Copy link
Member

Close #3131.

Nil receiver can be properly handled and all other `Param`'s mathods
are defined on a pointer.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Restrict the number of Rules, Contracts and Groups. A part of #3131.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
pkg/neorpc/result/application_log.go Outdated Show resolved Hide resolved
pkg/neorpc/types.go Show resolved Hide resolved
A part of #3131, follow the neo-project/neo-modules#827.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
A part of #3131, follow the notion of neo-project/neo-modules#827,
but don't restrict request line size due to golang/go#15494.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (1d189fd) 85.36% compared to head (d511f6e) 85.30%.
Report is 15 commits behind head on master.

Files Patch % Lines
pkg/services/rpcsrv/server.go 67.85% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3221      +/-   ##
==========================================
- Coverage   85.36%   85.30%   -0.06%     
==========================================
  Files         326      326              
  Lines       43945    43970      +25     
==========================================
- Hits        37512    37507       -5     
- Misses       4951     4984      +33     
+ Partials     1482     1479       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roman-khimov roman-khimov merged commit 61d5b6e into master Nov 23, 2023
14 of 18 checks passed
@roman-khimov roman-khimov deleted the json-limits branch November 23, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit JSON unmarshaller schemes for max allowed nested depth
2 participants