-
Notifications
You must be signed in to change notification settings - Fork 85
cli: allow dynamic contract hash for contract bindings #3405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
54ae67a
to
391a749
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjust commit and PR title, it's not quite correct.
391a749
to
66b8232
Compare
0e92b47
to
63f7877
Compare
3874358
to
e0aec55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/cli: add dynamic binding contract hash
/smartcontract: support dynamic contract hash for bindings
Or something like that.
e0aec55
to
9a7b1ec
Compare
I would like to ensure that generated wrapper with dynamic hash is valid. Can we create a test (using neotest): generate wrapper with dynamic hash for some test contract (we may reuse one of the already existing test contracts), create a tiny helper contract that uses this wrapper inside some simple API (that creates an instance of Contract and calls its method):
Then deploy both contract and helper, then call helper and check that everything works as expected. |
5bb8429
to
05d5265
Compare
fafb89a
to
40426e6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3405 +/- ##
==========================================
+ Coverage 86.08% 86.09% +0.01%
==========================================
Files 331 331
Lines 38107 38106 -1
==========================================
+ Hits 32805 32808 +3
+ Misses 3785 3782 -3
+ Partials 1517 1516 -1 ☔ View full report in Codecov by Sentry. |
40426e6
to
79c90ae
Compare
d8a3497
to
7c63898
Compare
7c63898
to
2ae6c0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM.
2ae6c0e
to
62c439a
Compare
62c439a
to
4a17da7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the commit message: Add an option to contract wrappers with dynamic hashes.
It's not quite correct, because there were no contract wrappers with dynamic hashes before this PR.
Otherwise LGTM.
Allow dynamic contract hash for contract bindings. Close #3007 Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
4a17da7
to
c5dbecb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roman-khimov, ready for review if you'd like to.
Close #3007