crypto: add StringCompressed() for PublicKey #3408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
requested review from
AnnaShaleva and
roman-khimov
as code owners
AnnaShaleva
reviewed
Apr 9, 2024
AliceInHunterland
force-pushed
the
hex-string-pub
branch
2 times, most recently
from
76d3daf to
eee485c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3408 +/- ##
==========================================
+ Coverage 86.08% 86.10% +0.01%
==========================================
Files 331 331
Lines 38107 38108 +1
==========================================
+ Hits 32805 32812 +7
+ Misses 3785 3781 -4
+ Partials 1517 1515 -2 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
reviewed
Apr 10, 2024
AliceInHunterland
force-pushed
the
hex-string-pub
branch
from
eee485c to
51c02c1
Compare
AliceInHunterland
changed the title
|
Contribution guideline job is failing. |
Add StringCompressed to get a string representation of the key in compressed form. Close #3263 Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland
force-pushed
the
hex-string-pub
branch
from
51c02c1 to
fc79d38
Compare
AnnaShaleva
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3263