services: add default values for NeoFSBlockFetcher configuration #3742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
requested review from
AnnaShaleva and
roman-khimov
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3742 +/- ##
==========================================
+ Coverage 82.96% 83.04% +0.07%
==========================================
Files 335 335
Lines 46763 46769 +6
==========================================
+ Hits 38799 38837 +38
+ Misses 6369 6335 -34
- Partials 1595 1597 +2 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
reviewed
Dec 11, 2024
AliceInHunterland
force-pushed
the
default-blockfetcher-config
branch
from
311eda4 to
9e09f56
Compare
|
@AliceInHunterland, please rebase onto fresh master and fix unresolved conversations. |
AliceInHunterland
force-pushed
the
default-blockfetcher-config
branch
from
9e09f56 to
e59780a
Compare
AliceInHunterland
force-pushed
the
default-blockfetcher-config
branch
from
e59780a to
aecbbd7
Compare
AnnaShaleva
reviewed
Dec 12, 2024
AliceInHunterland
force-pushed
the
default-blockfetcher-config
branch
from
aecbbd7 to
f8dd270
Compare
AliceInHunterland
force-pushed
the
default-blockfetcher-config
branch
from
f8dd270 to
0dfc85e
Compare
AnnaShaleva
reviewed
Dec 13, 2024
The minimum sufficient configuration is Addresses and ContainerID,
example:
```
NeoFSBlockFetcher:
Enabled: true
Addresses:
- st1.storage.fs.neo.org:8080
- st2.storage.fs.neo.org:8080
- st3.storage.fs.neo.org:8080
- st4.storage.fs.neo.org:8080
ContainerID: "87JRc7vyWcjW8uS32LMoLTAj4ckCzFZWfKbacjU3sAob"
```
Close #3718
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland
force-pushed
the
default-blockfetcher-config
branch
from
0dfc85e to
65bdc82
Compare
AnnaShaleva
approved these changes
Dec 13, 2024
AnnaShaleva
added a commit
that referenced
this pull request
Dec 13, 2024
Follow #3742. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
that referenced
this pull request
Dec 13, 2024
Follow #3742. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
that referenced
this pull request
Dec 13, 2024
Follow #3742. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
that referenced
this pull request
Dec 13, 2024
Follow #3742. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum sufficient configuration is Addresses and ContainerID, for example:
Close #3718