cli: refactor neofs-sdk-go related operations in upload-bin

[AliceInHunterland]

No description provided.

[AliceInHunterland]

Haven't found the place where

decode constructors are available now, u may find them useful https://github.com/nspcc-dev/neofs-sdk-go/blob/0b9bb748ea16370c9b88090a902413324e86bcf1/container/id/id.go#L40

can be useful yet.

we are operating with OIDs as bytes. example:
copy(buf[blockIndex%indexFileSize*oid.Size:], resOid[:])

@cthulhu-rider is it okay/correct?

[AliceInHunterland]

Check with the uploader and fetcher.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.11%. Comparing base (388ee25) to head (39cec7d).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
cli/util/upload_bin.go	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3756      +/-   ##
==========================================
+ Coverage   83.03%   83.11%   +0.07%     
==========================================
  Files         335      335              
  Lines       46752    46748       -4     
==========================================
+ Hits        38821    38855      +34     
+ Misses       6337     6297      -40     
- Partials     1594     1596       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AnnaShaleva]

#3756 (comment)

@AliceInHunterland create an issue for that, we'll reuse decoders instead of raw bytes copying. We're OK with the current version for now.

Please, write back once you check the updated version on small index files.

[cthulhu-rider]

we are operating with OIDs as bytes

yep, now this is legit for any ID, they are fixed as arrays and comparable

[AliceInHunterland]

Checked

[cthulhu-rider]

Haven't found the place where

neo-go/cli/util/upload_bin.go

Lines 56 to 57 in 388ee25

	var containerID cid.ID
	if err = containerID.DecodeString(containerIDStr); err != nil {

can now be

containerID, err := containerID.DecodeString(containerIDStr)
if err != nil {

just another way, but mb u find var declaration better