cli: add warning for duplicated index files in upload-bin

[AliceInHunterland]

Close #3762

[AnnaShaleva]

Have you located the reason?

[AliceInHunterland]

Have you located the reason?

Left comment here #3762 (comment)

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.06%. Comparing base (24f81a7) to head (c669ae3).
Report is 7 commits behind head on master.

Files with missing lines	Patch %	Lines
cli/util/upload_bin.go	0.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3763      +/-   ##
==========================================
- Coverage   83.07%   83.06%   -0.01%     
==========================================
  Files         335      335              
  Lines       46746    46745       -1     
==========================================
- Hits        38832    38829       -3     
- Misses       6322     6324       +2     
  Partials     1592     1592              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[roman-khimov]

Can this be fixed? Like checking for validity and deleting the one with lower hash?

[AnnaShaleva]

Like checking for validity and deleting the one with lower hash?

We can, but do we really need this? It will complicate the process of uploading, whereas duplicating index files don’t hurt BlockFetcher, it always uses the first one.

I’d say that we need to properly handle uploading error in order not to retry if the object was stored.

And if it comes to audit of uploaded results, then I’d suggest to make a separate audit service in order to include not only index files maintenance, but also block objects verification. It sounds like a fully qualified separate issue to me.

[roman-khimov]

I’d say that we need to properly handle uploading error in order not to retry if the object was stored.

NeoFS wouldn't be NeoFS if this was easy. You can PUT an object, get an incomplete placement error and still have it saved correctly (which is very likely the scenario we have here), it can be 1-2 replicas instead of 3 initially, but NeoFS will fix it eventually. The only way to check is SEARCH/GET.

make a separate audit service

At least a script for now. It all will be a service eventually, but

It sounds like a fully qualified separate issue to me.

and I agree.

[AnnaShaleva]

Let's have #3764 for audit, and for now I'd leave upload-bin as it is.