Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support connections over unix sockets #354

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

telepenin
Copy link

Hello, this PR provided support connections over unix sockets to nsqd.

According PR to nsq

@telepenin
Copy link
Author

Tests are provided, but now it will failure on the github workflow due to unable tests against master branch of nsq.

@mreiferson
Copy link
Member

Gonna leave this one for @ploxiln since you've been working with him on nsqio/nsq#1434

fi

if ! which nsqlookupd >/dev/null; then
echo "missing nsqlookupd binary" && exit 1
echo "missing nsqlookupd binary" && exit 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not change the 4-space indent to 2-space indent in the shells scripts

(4 space indent is the style we use for shell, and also it unnecessarily increases the diff to review)

@ploxiln
Copy link
Member

ploxiln commented Feb 26, 2023

there are some test failures:

 === RUN   TestUnixSocketProducerConnection
    producer_unix_socket_test.go:24: should lazily connect - dial tcp: address /tmp/nsqd.sock: missing port in address
--- FAIL: TestUnixSocketProducerConnection (0.00s)
=== RUN   TestUnixSocketProducerPing
    producer_unix_socket_test.go:46: should connect on ping
--- FAIL: TestUnixSocketProducerPing (0.00s)
=== RUN   TestUnixSocketProducerPublish
    producer_unix_socket_test.go:69: error dial tcp: address /tmp/nsqd.sock: missing port in address
--- FAIL: TestUnixSocketProducerPublish (0.00s)

@ploxiln
Copy link
Member

ploxiln commented Feb 27, 2023

... also I think we may need to add an un-released version of nsqd to the test matrix, and mask the new tests with a build tag that we enable only when testing against the newest build of nsqd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants