-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support connections over unix sockets #354
base: master
Are you sure you want to change the base?
Conversation
Tests are provided, but now it will failure on the github workflow due to unable tests against master branch of nsq. |
Gonna leave this one for @ploxiln since you've been working with him on nsqio/nsq#1434 |
fi | ||
|
||
if ! which nsqlookupd >/dev/null; then | ||
echo "missing nsqlookupd binary" && exit 1 | ||
echo "missing nsqlookupd binary" && exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not change the 4-space indent to 2-space indent in the shells scripts
(4 space indent is the style we use for shell, and also it unnecessarily increases the diff to review)
there are some test failures:
|
... also I think we may need to add an un-released version of nsqd to the test matrix, and mask the new tests with a build tag that we enable only when testing against the newest build of nsqd. |
Hello, this PR provided support connections over unix sockets to nsqd.
According PR to nsq