[Snyk] Fix for 2 vulnerabilities

[nssuwan186-dev]

Snyk has created this PR to fix 2 vulnerabilities in the pip dependencies of this project.

Snyk changed the following file(s):

• python/third_party/TradingAgents/requirements.txt

⚠️ Warning

yfinance 1.1.0 requires curl-cffi, which is not installed.
yfinance 1.1.0 has requirement websockets>=13.0, but you have websockets 11.0.3.
onnxruntime 1.14.1 has requirement numpy>=1.21.6, but you have numpy 1.21.3.
eodhd 1.0.32 requires matplotlib, which is not installed.
eodhd 1.0.32 has requirement pandas>=2.1.0, but you have pandas 1.3.5.
eodhd 1.0.32 has requirement websocket-client>=1.6.3, but you have websocket-client 1.6.1.
eodhd 1.0.32 has requirement numpy>=1.25.2, but you have numpy 1.21.3.
chromadb 0.4.14 requires tokenizers, which is not installed.
chromadb 0.4.14 has requirement numpy==1.21.6; python_version < "3.8", but you have numpy 1.21.3.

---

Important

• Check the changes in this PR to ensure they won't cause issues with your project.
• Max score is 1000. Note that the real score may have changed since the PR was raised.
• This PR was automatically created by Snyk using the credentials of a real user.
• Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

---

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

---

Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

[gemini-code-assist]

Summary of Changes

Hello @nssuwan186-dev, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, focuses on improving the security of the project by updating specific Python dependencies to patched versions. The primary goal is to resolve known vulnerabilities in protobuf and zipp without directly requiring them, ensuring the project's dependency tree is more secure.

Highlights

• Vulnerability Fixes: This pull request addresses two identified vulnerabilities within the project's pip dependencies.
• Dependency Updates: The protobuf and zipp packages have been updated to versions 6.33.5 and 3.19.1 respectively, to mitigate these vulnerabilities.
• Automated Remediation: The changes were automatically generated by Snyk, a security scanning tool, to provide a direct fix.

Changelog

• python/third_party/TradingAgents/requirements.txt
  • Pinned protobuf to version 6.33.5 to address a vulnerability.
  • Pinned zipp to version 3.19.1 to address a vulnerability.

Activity

• This pull request was automatically created by Snyk to propose fixes for identified vulnerabilities.
• The PR description includes a warning section detailing several potential dependency conflicts or missing packages (e.g., yfinance requiring curl-cffi, websockets version mismatch, onnxruntime and numpy mismatch, eodhd dependency issues, chromadb issues).
• Links to Snyk's project report, PR template customization, project settings, and upgrade logic documentation are provided.
• An interactive lesson on vulnerability from Snyk Learn is also linked.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request from Snyk aims to fix two vulnerabilities by pinning protobuf and zipp in requirements.txt. While this change addresses the immediate security concerns for an environment built from this file, it highlights a larger issue of inconsistent dependency management. The project has dependencies declared in pyproject.toml (with a uv.lock file), setup.py, and requirements.txt. This can lead to discrepancies between environments and future maintenance challenges. My review comment suggests a more robust approach by consolidating dependency management into pyproject.toml to ensure consistency and long-term project health.

[gemini-code-assist]

While pinning these transitive dependencies in requirements.txt might resolve the reported Snyk vulnerabilities for one installation path, it doesn't address the root cause and introduces further inconsistency. This project defines dependencies in multiple places (pyproject.toml, setup.py, and this requirements.txt), which is a significant maintenance concern and can lead to unpredictable environments.

The presence of pyproject.toml and uv.lock suggests uv is the intended package manager. The best practice is to consolidate all dependency management within pyproject.toml to create a single source of truth.

To properly resolve these vulnerabilities, I recommend adding explicit constraints to pyproject.toml and regenerating the lock file. For example, to fix the protobuf vulnerability, you should add protobuf >= "6.33.5" to the dependencies in python/third_party/TradingAgents/pyproject.toml. After updating pyproject.toml, run uv lock to update the lock file.

This approach will fix the vulnerability correctly for the uv-based workflow and is a step towards a more maintainable dependency setup. I recommend removing these additions to requirements.txt and instead updating pyproject.toml.