-
Notifications
You must be signed in to change notification settings - Fork 272
Ability to mock protected methods with and without return value #845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! WDYT @Romfos ?
… unit tests to verify error conditions * Rename unit tests with better description * Fix unit test failure due to orphaned argument spec when previous setup throws
holding my breath for this one. |
Hi @Romfos , Just wanted to check you're happy with this change? |
@dtchepak sorry, I'm not fully qualified how this part of code is working. Could you please review by yourself? |
@dtchepak let me know if you have any additional suggestions or if you're happy to merge this? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. Looks great, thanks!
Closes #800