Skip to content

Ability to mock protected methods with and without return value #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 9, 2025

Conversation

Jason31569
Copy link
Contributor

Closes #800

@Jason31569 Jason31569 changed the title Ability to mock protected methods with and without return types (void) Ability to mock protected methods with and without return value Nov 20, 2024
@dtchepak dtchepak requested a review from Romfos November 30, 2024 08:22
Copy link
Member

@dtchepak dtchepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! WDYT @Romfos ?

… unit tests to verify error conditions

* Rename unit tests with better description
* Fix unit test failure due to orphaned argument spec when previous setup throws
@leus
Copy link

leus commented Jan 6, 2025

holding my breath for this one.

@dtchepak
Copy link
Member

Hi @Romfos ,

Just wanted to check you're happy with this change?

@Romfos
Copy link
Contributor

Romfos commented Feb 16, 2025

@dtchepak sorry, I'm not fully qualified how this part of code is working. Could you please review by yourself?

@Jason31569
Copy link
Contributor Author

@dtchepak let me know if you have any additional suggestions or if you're happy to merge this? Thank you.

Copy link
Member

@dtchepak dtchepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Looks great, thanks!

@dtchepak dtchepak merged commit ee11ef0 into nsubstitute:main Mar 9, 2025
9 checks passed
@Jason31569 Jason31569 mentioned this pull request Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to mock requests from Protected methods in sequences
4 participants