TypeScript Rollout Tier 10 - Datetimepicker #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrites `Datetimepicker` in the `src/components/datetimepicker` folder in TypeScript: - `modelValue` allow `null` - Replaces `isNaN(date)` with `isNaN(date.valueOf())` which should produce an equivalent result - Introduces new types: - `DatetimeFormatter`: type of the `datetimeFormatter` prop - `DatetimeParser`: type of the `datetimeParser` prop - `DatetimeCreator`: type of the `datetimeCreator` prop Here is a tip for TypeScript migration: - Register Buefy components with "direct" names rather than the `name` fields so that they are type-checked
Rewrites the spec for `Datetimepicker` in the `src/components/datetimepicker` folder in TypeScript. All the changes are straightforward. Here are a tip for Jest → Vitest migration: - Import the spec building blocks from the `vitest` package
`rollup.config.mjs` removes "datetimepicker" from `JS_COMPONENTS`.
Rewrites the documentation for `Datetimepicker` in the `src/pages/components/datetimepicker` folder in TypeScript. In `examples/ExEditable.vue`: - Adds a missing field `enableSeconds` to `data`, which is `false` anyway Other changes are straightforward. Here is a tip for TypeScript migration: - Explicitly import and register components so that they are type checked. Note that no type-checking is performed for globally registered components.
wesdevpro
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues:
Proposed Changes
datetimepicker