Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript Rollout Tier 14 - docs Customization #400

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

kikuomax
Copy link
Collaborator

Related issues:

Proposed Changes

  • Migration of packages/docs/src/pages/installation/Customization.vue

Rewrites `src/pages/installation/Customization.vue` in TypeScript.

Fixes the issue that Vite complained about the missing `buefy` package,
which was not actually used. This was caused by the code snippets in
`Customization.vue`, which Vite conufsed with the actual code and tried
to translate them. Moves these code snippets to a separate TypeScript
file `usage/customization.ts`.

Here is a tip for TypeScript migration:
- Explicitly import and register Buefy components so that they are
  type-checked. Note that no type-checking is performed for globally
  registered components.
@kikuomax kikuomax requested a review from wesdevpro January 15, 2025 13:54
@kikuomax kikuomax merged commit 02b2962 into ntohq:dev Jan 16, 2025
18 checks passed
@kikuomax kikuomax deleted the ts-rollout-tier-14-docs-customization branch January 16, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants