Skip to content

Conversation

@derekpierre
Copy link
Member

@derekpierre derekpierre commented Aug 16, 2023

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Other

Required reviews:

How many reviews does the PR author need?

  • 1
  • 2
  • 3

What this does:
Based over #155 (which is based over #149 )
Related to:

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on?
Is there a particular commit/function/section of your PR that requires more attention from reviewers?

@derekpierre derekpierre changed the title [WIP] Changes needed for ACP, ThresholdMessageKit work [WIP] Changes needed for ACP, ThresholdMessageKit work in nucypher-core Aug 16, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #156 (2c1288b) into main (03b4e35) will decrease coverage by 0.09%.
The diff coverage is 74.12%.

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
- Coverage   77.96%   77.88%   -0.09%     
==========================================
  Files          23       23              
  Lines        4979     5033      +54     
==========================================
+ Hits         3882     3920      +38     
- Misses       1097     1113      +16     
Files Changed Coverage Δ
ferveo-common/src/lib.rs 0.00% <0.00%> (ø)
ferveo/src/bindings_wasm.rs 0.00% <0.00%> (ø)
ferveo/src/bindings_python.rs 51.33% <37.93%> (-0.65%) ⬇️
ferveo/src/api.rs 88.95% <78.26%> (-1.01%) ⬇️
tpke/src/ciphertext.rs 97.96% <93.44%> (+8.55%) ⬆️
ferveo/src/dkg.rs 96.11% <100.00%> (ø)
ferveo/src/lib.rs 97.44% <100.00%> (ø)
ferveo/src/pvss.rs 91.70% <100.00%> (ø)
tpke/src/context.rs 98.03% <100.00%> (-0.15%) ⬇️
tpke/src/decryption.rs 70.49% <100.00%> (+0.57%) ⬆️
... and 1 more

@derekpierre derekpierre changed the title [WIP] Changes needed for ACP, ThresholdMessageKit work in nucypher-core Changes needed for ACP, ThresholdMessageKit work in nucypher-core Aug 22, 2023
@derekpierre derekpierre marked this pull request as ready for review August 22, 2023 20:31
@KPrasch KPrasch merged commit e2c4c2e into nucypher:main Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Completed

Development

Successfully merging this pull request may close these issues.

5 participants