Skip to content

Conversation

@fjarri
Copy link
Collaborator

@fjarri fjarri commented Nov 6, 2025

Type of PR:

  • Feature

Required reviews:

  • 1

What this does:

  • ThresholdDecryptionResponse.__init__ now takes a typed decryption_share instead of bytes
  • correspondingly, ThresholdDecryptionResponse.decryption_share is also typed

Issues fixed/closed:

Notes:
This changes the ABI of ThresholdDecryptionResponse

For a test I used a pre-serialized DecryptionShareSimple. Making it via the API is possible, but much more complicated.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 24.00000% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.60%. Comparing base (293403e) to head (f80393c).

Files with missing lines Patch % Lines
nucypher-core-python/src/lib.rs 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   59.77%   59.60%   -0.17%     
==========================================
  Files          19       19              
  Lines        4097     4112      +15     
==========================================
+ Hits         2449     2451       +2     
- Misses       1648     1661      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fjarri fjarri changed the title Add typing to Python bindings of ThresholdDecryptionResponse Add typing to ThresholdDecryptionResponse.decryption_share Nov 6, 2025
@fjarri
Copy link
Collaborator Author

fjarri commented Nov 6, 2025

See the comment in #121. Cannot be fixed at the moment due to some unfortunate design choices. Closing.

@fjarri fjarri closed this Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor ThresholdDecryptionResponse

2 participants