Release v0.14.0 #89
Merged
Release v0.14.0 #89
+38
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-roslaniec
requested review from
KPrasch,
cygnusv,
derekpierre,
manumonti and
theref
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
- Coverage 23.46% 23.45% -0.01%
==========================================
Files 18 18
Lines 3520 3521 +1
==========================================
Hits 826 826
- Misses 2694 2695 +1 ☔ View full report in Codecov by Sentry. |
piotr-roslaniec
force-pushed
the
release-0.14.0
branch
from
5bdb029 to
83a30c7
Compare
piotr-roslaniec
force-pushed
the
release-0.14.0
branch
from
83a30c7 to
9729a42
Compare
derekpierre
reviewed
Jan 12, 2024
CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
|
|
||
| - Fixed Python typings for `ThresholdMessageKit.decrypt_with_shared_secret()` and `combine_decryption_shares_simple()` ([#84]) |
Member
There was a problem hiding this comment.
Is #84 a breaking change for "compatibility" if it is purely related to the binding signature, and not the underlying method? If it isn't a breaking change, could this instead be in a Fixed block instead of in the Changed and put below the Added block?
Of course #83 is indeed a breaking change and should be left here, just channeling my inner Bogdan for changelogs format. 😄
Contributor
Author
There was a problem hiding this comment.
Indeed, it's a Fixed change. Fixed.
piotr-roslaniec
force-pushed
the
release-0.14.0
branch
from
ea1f35b to
9fb1200
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Why it's needed:
taco-webNotes for reviewers:
@nucypher/nucypher-core:0.14.1, because I accidentally released WASM bundled with the old method instead of the new inlined method