Separate condition deserialization from base Condition via ConditionFactory #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ConditionFactory. Create constants for string literals used for condition type.
derekpierre
requested review from
KPrasch,
cygnusv,
manumonti,
piotr-roslaniec and
theref
Codecov Report
@@ Coverage Diff @@
## alpha #292 +/- ##
==========================================
+ Coverage 80.99% 81.25% +0.25%
==========================================
Files 36 36
Lines 1021 1035 +14
Branches 110 110
==========================================
+ Hits 827 841 +14
Misses 186 186
Partials 8 8
|
manumonti
approved these changes
Sep 6, 2023
Contributor
manumonti
left a comment
manumonti
left a comment
There was a problem hiding this comment.
LGTM 👏
I like these changes
piotr-roslaniec
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Some cleanup, post #267
Issues fixed/closed:
Why it's needed:
Notes for reviewers:
Is the use of exported constant types the best way? Static members could be alternatives?