Skip to content

Conversation

@derekpierre
Copy link
Member

@derekpierre derekpierre commented Nov 13, 2025

NOTE: Before merging: update version of nucypher-core used - a new dev release will be needed

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

Depends on nucypher/nucypher-core#126

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network. E.g.,
if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on? Is there a particular commit/function/section
of your PR that requires more attention from reviewers?

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the nonce handling in UserOperation and PackedUserOperation to support uint256 values by converting them to strings internally. It also changes the @nucypher/nucypher-core dependency from an npm package version to a local linked directory for development purposes.

  • Introduces getUint256String helper function to convert nonce values from bigint/number to string
  • Updates test assertions to compare nonce values as strings
  • Refactors tests to use helper functions (toCoreUserOperation, toCorePackedUserOperation) instead of direct constructors

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pnpm-lock.yaml Updates dependency resolution to use local link for @nucypher/nucypher-core
packages/test-utils/package.json Changes dependency to local path ../../../nucypher-core/nucypher-core-wasm-bundler
packages/taco/package.json Changes dependency to local path ../../../nucypher-core/nucypher-core-wasm-bundler
packages/shared/package.json Changes dependency to local path ../../../nucypher-core/nucypher-core-wasm-bundler
packages/pre/package.json Changes dependency to local path ../../../nucypher-core/nucypher-core-wasm-bundler
package.json Changes dependency to link:../nucypher-core/nucypher-core-wasm-bundler
packages/shared/src/types.ts Adds getUint256String function and updates nonce handling to use string representation
packages/shared/test/porter.test.ts Removes unused imports and refactors to use helper functions for creating UserOperation objects
packages/taco/test/taco-sign.test.ts Updates nonce comparison logic to compare string representations
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@derekpierre derekpierre changed the title [WIP] Nonce uint256 [WIP] Nonce as uint256 Nov 17, 2025
@derekpierre derekpierre changed the title [WIP] Nonce as uint256 Nonce as uint256 Nov 20, 2025
@derekpierre derekpierre marked this pull request as ready for review November 20, 2025 14:28
@derekpierre derekpierre mentioned this pull request Nov 20, 2025
30 tasks
@derekpierre derekpierre mentioned this pull request Nov 20, 2025
7 tasks
… regarding nonce value being provided as uint256 string.
…ide nonce as a string.

Update tests to account for nonce being returned as a string.
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (signing-epic@2d11ff3). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             signing-epic     #739   +/-   ##
===============================================
  Coverage                ?   90.13%           
===============================================
  Files                   ?       97           
  Lines                   ?     8453           
  Branches                ?      296           
===============================================
  Hits                    ?     7619           
  Misses                  ?      831           
  Partials                ?        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@derekpierre derekpierre merged commit fc47c97 into nucypher:signing-epic Nov 20, 2025
4 checks passed
@derekpierre derekpierre mentioned this pull request Nov 20, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants