Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CBP get users by group #295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paoloromolini
Copy link
Contributor

PR reopened in place of #291
following @JinHuangAtZen comments.

Signed-off-by: Paolo Romolini <paolo.romolini@enterprisedb.com>
Copy link
Contributor

@JinHuangAtZen JinHuangAtZen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @paoloromolini, I think there is one step missing, which is generate the mock client as mentioned in the readme https://github.com/nukosuke/go-zendesk#to-regenerate-the-mock-client.
After running the go generate ./..., you will see the updated client.go file with the newly added functions. That's why the test fail.

@paoloromolini
Copy link
Contributor Author

Hi @JinHuangAtZen I got this error when running the command:

go generate ./...                                                                                                                                                                                           [9:14:40]
2023/11/09 09:16:33 Loading input failed: api.go:8:2: unknown embedded interface AppAPI
zendesk/api.go:4: running "mockgen": exit status 1

@JinHuangAtZen
Copy link
Contributor

Hi @JinHuangAtZen I got this error when running the command:

go generate ./...                                                                                                                                                                                           [9:14:40]
2023/11/09 09:16:33 Loading input failed: api.go:8:2: unknown embedded interface AppAPI
zendesk/api.go:4: running "mockgen": exit status 1

Hi @paoloromolini , I've made a new PR with all your changes here #296 and it's passing the tests. I think the issue you see is because this library was recently upgraded to use https://github.com/uber-go/mock, it might not installed in your local dev environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants