build: Link to libmusicbrainzcc, not libmusicbrainz #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix linking when the ENABLE_MUSICBRAINZ option is true. This was regressed in 8e7f8ef, by linking to the libmusicbrainz (C) library instead of the libmusicbrainzcc (C++) library causing undefined symbols.
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Nov 18, 2024
nullobsi/cantata#46 MFH: 2024Q4 (cherry picked from commit c32214b)
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Nov 18, 2024
nullobsi
approved these changes
Nov 19, 2024
|
@BSDKaffee @nullobsi If libmusicbrainz was built from libmusicbrainz-5.1.0.tar.gz, libmusicbrainz5cc is not provided. So a fallback is needed. |
|
2f97f1f54a6a8902080091da86f7a58e7d5056fa I see what you mean. |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jun 17, 2025
https://build.opensuse.org/request/show/1286209 by user RN + anag_factory - Update to version 3.3.1: * build: Link to libmusicbrainzcc, not libmusicbrainz (gh#nullobsi/cantata#46) * build: update flatpak workflow (gh#nullobsi/cantata#53) * Add missing QRegularExpression include (gh#nullobsi/cantata#54) * fix FindCDParanoia.cmake (gh#nullobsi/cantata#51) * git: bump version by (gh#nullobsi/cantata#60) * fix: fill tags from filename if tag is empty in metadata (gh#nullobsi/cantata#64) * build: fix musicbrainz (gh#nullobsi/cantata#65) * rc: v3.3.1 (2) (gh#nullobsi/cantata#66) - Superseded cantata-add-missing-qregularexpression-include.patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix linking when the ENABLE_MUSICBRAINZ option is true. This was regressed in 8e7f8ef, by linking to the libmusicbrainz (C) library instead of the libmusicbrainzcc (C++) library causing undefined symbols.