-
Notifications
You must be signed in to change notification settings - Fork 13
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: re-export NDS themes to be used as an escape hatch
In v11, NDS introduced context-specific default themes. Directly importing themes from NDS would result in using the wrong theme, causing conflicts between custom app themes, desktop, and touch variants. While the work-arounds provided at the time were sufficient for most use cases, some required a direct import of the theme. This release re-introduces the theme exports as an escape hatch to *only* be used when the work-arounds outlined in v11 release notes are insufficient. The release exports the `desktop`, `phone`, `tablet` themes as well as a `themes` object which has the type of `Record<"legacy" | "experimental" | "tablet" | "phone", DefaultNDSThemeType>` to be used for dynamic theme lookup Example usage: `import { desktop as theme } from "@nulogy/components";`
- Loading branch information
1 parent
dc20bd6
commit 0a5ddf4
Showing
5 changed files
with
16 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
export { themes, phone, tablet, legacy as desktop } from "./theme"; | ||
export type { ThemeType, DefaultNDSThemeType, Breakpoints } from "./theme.type"; | ||
export type { ThemeType, DefaultNDSThemeType } from "./theme.type"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters