Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a key prop for the table column #1299

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Conversation

haideralsh
Copy link
Contributor

@haideralsh haideralsh commented Oct 30, 2023

Description

This change allows the user to pass a key prop when a dataKey is not applicable for that given column. This could be used for columns that compose data from multiple columns, actions, or decorative columns.

Similar to the dataKey, The key needs to be unique.

Linked issue

Fixes #1292

Changes include

  • breaking change: a change that is not backwards-compatible and/or changes current functionality
  • fix: a non-breaking change that solves an issue
  • feature: a non-breaking change that adds functionality
  • chore: contains no changes affecting the library, such as documentation or test updates

Feature checklist

  • Appropriate tests have been added
  • Documentation has been updated
  • Accessibility has been considered

@haideralsh haideralsh force-pushed the fix/add-table-column-key branch from fc0409f to 36e9db3 Compare October 30, 2023 17:55
@haideralsh haideralsh force-pushed the fix/add-table-column-key branch from 36e9db3 to 899a689 Compare October 30, 2023 18:16
This change allows the user to pass a key prop when a dataKey is not applicable for that given column. This could be used for columns that compose data from multiple columns, actions, or decorative columns.

Similar to the dataKey, The key needs to be unique.

Fixes #1292
@haideralsh haideralsh force-pushed the fix/add-table-column-key branch from 899a689 to 8486717 Compare October 30, 2023 18:36
@haideralsh haideralsh merged commit 6f3c100 into master Nov 1, 2023
2 checks passed
@haideralsh haideralsh deleted the fix/add-table-column-key branch November 1, 2023 15:22
Copy link

github-actions bot commented Nov 1, 2023

🎉 This PR is included in version 8.15.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ColumnType has dataKey masked optional and it's used as key for columns
1 participant